Modify

Opened 8 years ago

Last modified 4 years ago

#7376 accepted defect

dropbear init script always reads enabled

Reported by: fred <goshmo@…> Owned by: jow
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: Cc: maddes

Description

According to the docs, setting dropbear option "enabled" to 0 should disable it at startup. dropbear init script is reading "enable" instead of "enabled", so the default value is always returned. The following line in dropbear_start()

config_get_bool enabled "${section}" enable 1

should be

config_get_bool enabled "${section}" enabled 1

Attachments (0)

Change History (5)

comment:1 Changed 8 years ago by jow

  • Owner changed from developers to jow
  • Status changed from new to accepted

comment:2 Changed 8 years ago by maddes

Another way would be to update the docs (I assume the Wiki is meant here).

Is there an OpenWrt default if it should be called "enable" or "enabled"?

comment:3 Changed 8 years ago by maddes

Fixed the wiki page at http://wiki.openwrt.org/doc/uci/dropbear to show the current state.

My personal preference is "enable", as is "verbose".
The config says "enable this" and the script checks if has to be enabled.

comment:4 Changed 7 years ago by maddes

  • Cc maddes added

comment:5 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as accepted .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.